-
Notifications
You must be signed in to change notification settings - Fork 90
Update bootstrap #1944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update bootstrap #1944
Conversation
47fed61
to
ae46bba
Compare
f773ad8
to
821eb06
Compare
@Fryguy I fixed the conflicts here if you can review again when you have time |
Why is popper added directly. That is, won't it just come in naturally as a dependency? |
ok, so from what I understand - the better way to declare missing peer dependencies is to use packageExtensions. This allows you to essentially force bootstrap to pull in the dependency (and we don't have to declare it as "our" dependency. So in the .yarnrc.yml you would add something like: packageExtensions:
"bootstrap@*":
dependencies:
"popper.js": "~1.16.1" |
f1be072
to
6bbf4c1
Compare
This pull request is not mergeable. Please rebase and repush. |
5588019
to
b96b2a2
Compare
@Fryguy I fixed the dependency issue if you can review this again when you get a chance. |
440078f
to
d5a61cd
Compare
d5a61cd
to
d82b19d
Compare
Checked commit GilbertCherrie@d82b19d with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.62.0, and yamllint **
|
@Fryguy I think this pr is good to merge if you can review |
@elsamaryv please review |
Update Bootstrap to 4.0.0. Also added popper.js since it is a dependency of bootstrap 4.0.0